test(e2e): add emission coverage for triggers, action-pins, breaking-gate#344
Merged
Conversation
…gate Adds e2e scenarios asserting generated-workflow constructs that the live fleet cannot drive: extra orchestrate triggers (schedule/repository_dispatch/workflow_run/merge_group), pin_mode sha vs default mutable refs plus per-action overrides, and the release/promote breaking-change gate. merge_queue emission was already covered (scenario 15 + unit tests). Closes #324, closes #327, closes #322. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
ReleaseConfig has a Workflow field (the release-build callback workflow path), but the JSON schema's releaseConfig omitted it with additionalProperties:false, so a manifest using release.workflow failed schema validation despite cascade accepting it. Add the property and sync all three on-disk schema copies. Surfaced by the new promote-breaking-gate-release-build e2e scenario. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #324, #327, #322.
Adds e2e scenarios asserting generated-workflow constructs the LIVE fleet cannot drive (so they belong in the act+gitea/emission layer):
34-extra-orchestrate-triggers.yaml): schedule/cron, repository_dispatch types, workflow_run, merge_group.35/36/39):pin_mode: shaemits 40-hex SHAs (mutable ref absent); default emits mutable@v6; per-action override wins over sha mode.37/38): single-env release breaking-change gate (Check Breaking Changes,can_proceed, dry-run guard, non-cancelling concurrency) and multi-env promote--allow-breaking+ release-build dispatch.#319 merge_queueemission was already covered (scenario 15 + unit tests), so it is intentionally not duplicated. Harness gainsExtraTriggers/PinMode/ActionPinspassthrough. All contains-strings verified against real generator output; build + golangci-lint clean.